Add keyboard macros #305

Savid · 2025-03-29T08:10:39Z

[ui] add macros section to settings to create/edit/delete macros
[ui] add macro bar under the actionbar to execute macros
[server] add json rpc to get/set the macros
[server] save macros to config

Macro bar

Settings

CLAassistant · 2025-03-29T08:10:46Z

All committers have signed the CLA.

Nevexo · 2025-03-29T11:24:43Z

This looks amazing! Thanks for working on it.

Copilot

Pull Request Overview

This pull request implements support for keyboard macros by adding a macros section in both the settings UI and action bar, as well as introducing JSON RPC endpoints on the server to get and set macros.

Adds new UI components and routing for managing keyboard macros
Enhances client-side hooks and state management to support macro execution
Implements server-side API endpoints and configuration updates to persist macros

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
ui/src/routes/devices.$id.settings.tsx	Added a new navigation link for keyboard macros in settings
ui/src/main.tsx	Registered new routes for macros in the app routing configuration
ui/src/hooks/useKeyboard.ts	Added an executeMacro function to process macro steps
ui/src/hooks/stores.ts	Introduced macros state and functions to load and save keyboard macros
ui/src/components/WebRTCVideo.tsx	Integrated MacroBar component into the video layout
ui/src/components/MacroBar.tsx	New component rendering a macro bar with buttons for each macro
jsonrpc.go	Added JSON RPC handlers for getting and setting keyboard macros
config.go	Added configuration types and validation for keyboard macros

Files not reviewed (1)

ui/src/index.css: Language not supported

config.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adamshiervani

Amazing work — thanks for taking the time to put this together. It’s a superb implementation, and the attention to detail really shows. Much appreciated.

Most of the comments are around UI consistency and readability: use existing components where possible, and split the macro settings file into multiple routes to keep things clear.

ui/src/routes/devices.$id.settings.macros.tsx

…yling

adamshiervani

Even better second iteration
Arrows feel much better than DnD

ui/src/routes/devices.$id.settings.macros.tsx

ui/src/components/MacroForm.tsx

ui/src/components/MacroStepCard.tsx

ui/src/routes/devices.$id.settings.macros.tsx

ui/src/components/MacroForm.tsx

adamshiervani

I don't have too much left to say. You've done a wonderful job. Fix the remaining things from the last review, and these tiny change requests and then we should be able to merge

ui/src/routes/devices.$id.settings.macros.tsx

ui/src/routes/devices.$id.settings.macros.edit.tsx

Savid · 2025-04-09T13:46:48Z

i'm getting some local dev issues from this commit #336 when running ui from https://github.com/jetkvm/kvm/blob/dev/ui/dev_device.sh

adamshiervani · 2025-04-09T22:06:25Z

Fixed and merged in: #342

adamshiervani · 2025-04-10T20:51:41Z

Great work, @Savid! Will be included in the next version 0.4.0.

* add jsonrpc keyboard macro get/set * add ui keyboard macros settings and macro bar * use notifications component and handle jsonrpc errors * cleanup settings menu * return error rather than truncate steps in validation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat(ui): add className prop to Checkbox component to allow custom styling * use existing components and CTA * extract display key mappings * create generic combobox component * remove macro description * cleanup styles and macro list * create sortable list component * split up macro routes * remove sortable list and simplify * cleanup macrobar * use and add info to fieldlabel * add useCallback optimizations * add confirm dialog component * cleanup delete buttons * revert info on field label * cleanup combobox focus * cleanup icons * set default label for delay --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ReanimationXP · 2025-04-12T21:15:35Z

This is really awesome - I'm not sure what exactly the edit buttons do when viewing the macros steps, so maybe you already have this, but it would be cool to expand this for easy use with really long strings (one-liners, long passwords, password prefixes, api keys, etc). Could this be improved to support those use cases as well? It'd be nice to have like a text area for something like duckyscript rather than having to enter each character in one at a time via a GUI, so I could put common one-liners like "apt-get update; apt-get upgrade;ENTER" on a button without it being 5 pages long and taking half an hour to enter in :) (actual duckyscript would be slightly different but you get the idea. it supports specifying the delay and strings and other things too.)

Quick Intro: https://github.com/dekuNukem/duckyPad/blob/master/duckyscript_info.md
Full Reference: https://docs.hak5.org/hak5-usb-rubber-ducky/duckyscript-tm-quick-reference

I don't know that supporting the full spec would be necessary because DuckyScript 3 gets into if statements and so forth, but support for the basics like strings, special characters and escaping presumably, and special keys would be really really awesome. I can't purchase a unit right now due to US orders being shut down over tariffs, but I applied for a PoE beta unit, and if I were sent one I would happily look into making this a reality, and I'd love to have OP's help if they don't want to do it themselves :)

* add jsonrpc keyboard macro get/set * add ui keyboard macros settings and macro bar * use notifications component and handle jsonrpc errors * cleanup settings menu * return error rather than truncate steps in validation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat(ui): add className prop to Checkbox component to allow custom styling * use existing components and CTA * extract display key mappings * create generic combobox component * remove macro description * cleanup styles and macro list * create sortable list component * split up macro routes * remove sortable list and simplify * cleanup macrobar * use and add info to fieldlabel * add useCallback optimizations * add confirm dialog component * cleanup delete buttons * revert info on field label * cleanup combobox focus * cleanup icons * set default label for delay --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Savid added 2 commits March 29, 2025 18:05

add jsonrpc keyboard macro get/set

5650bad

add ui keyboard macros settings and macro bar

2ba8e19

Nevexo added component: ui component: usb/hid labels Mar 29, 2025

Savid added 2 commits March 30, 2025 22:13

use notifications component and handle jsonrpc errors

452e782

cleanup settings menu

2766f50

adamshiervani requested a review from Copilot April 1, 2025 22:40

Copilot AI reviewed Apr 1, 2025

View reviewed changes

config.go Outdated Show resolved Hide resolved

return error rather than truncate steps in validation

7cac289

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

adamshiervani requested changes Apr 1, 2025

View reviewed changes

Savid added 10 commits April 2, 2025 23:28

feat(ui): add className prop to Checkbox component to allow custom st…

c65d222

…yling

use existing components and CTA

669e424

extract display key mappings

6406400

create generic combobox component

223558a

remove macro description

5c3424e

cleanup styles and macro list

0206d79

create sortable list component

48d8523

split up macro routes

7b87258

remove sortable list and simplify

4438dbb

cleanup macrobar

54d0118

adamshiervani requested changes Apr 3, 2025

View reviewed changes

Savid added 7 commits April 3, 2025 23:15

use and add info to fieldlabel

0651cb8

add useCallback optimizations

8a05696

add confirm dialog component

5fcc1f4

cleanup delete buttons

7d5cf91

merge dev

10dbdf7

revert info on field label

95eb908

cleanup combobox focus

6b6b862

cleanup icons

40acb6e

Savid requested a review from adamshiervani April 5, 2025 14:06

adamshiervani requested changes Apr 7, 2025

View reviewed changes

ui/src/routes/devices.$id.settings.macros.tsx Outdated Show resolved Hide resolved

ui/src/routes/devices.$id.settings.macros.edit.tsx Outdated Show resolved Hide resolved

Savid added 2 commits April 9, 2025 23:08

Merge branch 'dev' into feat/macros

dc51218

set default label for delay

36d427b

Savid requested a review from adamshiervani April 9, 2025 13:45

adamshiervani approved these changes Apr 10, 2025

View reviewed changes

ym approved these changes Apr 10, 2025

View reviewed changes

adamshiervani merged commit af0f452 into jetkvm:dev Apr 10, 2025
8 checks passed

IDisposable mentioned this pull request May 15, 2025

fix(ui): Fix regression on Shift-Backspace not being handled #454

Merged

Add keyboard macros #305

Add keyboard macros #305

Uh oh!

Conversation

Savid commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Macro bar

Settings

Uh oh!

CLAassistant commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nevexo commented Mar 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

adamshiervani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adamshiervani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adamshiervani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Savid commented Apr 9, 2025

Uh oh!

adamshiervani commented Apr 9, 2025

Uh oh!

Uh oh!

adamshiervani commented Apr 10, 2025

Uh oh!

ReanimationXP commented Apr 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Savid commented Mar 29, 2025 •

edited

Loading

CLAassistant commented Mar 29, 2025 •

edited

Loading

ReanimationXP commented Apr 12, 2025 •

edited

Loading